Agoric / ui-kit

Components and tools for building graphical UIs
https://ui-kit-dwm.pages.dev/
Apache License 2.0
3 stars 3 forks source link

build: add dependencies for subpackages #87

Closed samsiegart closed 4 months ago

samsiegart commented 4 months ago

The publish NPM workflow is failing https://github.com/Agoric/ui-kit/actions/runs/8053306725/job/21995398192

It seems like it's not building and linking the packages in the order according to https://github.com/Agoric/ui-kit/blob/2ae3e210ed503eb5377532bd3b6161f9b85cf270/package.json#L5-L9, so @agoric/react-components fails to build because @agoric/web-components isn't built yet. It seems like the way to fix this is to declare the dependencies on other sub-packages in their package.jsons, which seems to be what agoric-sdk does for its sub-packages, but we'll see what happens when the workflow runs.

I also replaced an any type with the proper ChainStorageWatcher type in @agoric/web-components, now that the dependency is included.