search

Agoric / wallet-app

Site for wallet.agoric.app
https://wallet.agoric.app/
2 stars 7 forks source link

feat: add node selectors to connection settings #134

Closed samsiegart closed 9 months ago

samsiegart commented 9 months ago

fixes https://github.com/Agoric/wallet-app/issues/130

Adds auto-suggest inputs for rpc and api nodes. The suggestions are fetched from the currently selected network config. When the inputs are empty, it just defaults to a random node, so the inputs are not required.

Screenshot

image

cloudflare-workers-and-pages[bot] commented 9 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4762560
Status: ✅  Deploy successful!
Preview URL: https://21a47295.wallet-app.pages.dev
Branch Preview URL: https://node-selector.wallet-app.pages.dev

View logs

samsiegart commented 9 months ago

Changing Localhost API URL seems to throw

Fixed, it was throwing if apiAddrs (or rpcAddrs) was missing from the network config.

“Testnet” is not mapping to anything - should this be Emerynet?

Yea I think we used to have a "testnet" but not anymore, seems sensible to change to emerynet, just did.

Localhost uses origin instead of localhost - is this intentional?

Yea, the wallet app itself has a network config so you can edit it if you're running the UI locally, I just changed it to "Local" instead of "Localhost" though so it's not as potentially misleading. The "Localhost" I think implied that your chain was running on localhost, not the network config.