search

AgrDataSci / ClimMob-analysis

Workflow for data analysis applied on ClimMob.net
Creative Commons Attribution 4.0 International
0 stars 2 forks source link

00-check_packages should check and install tested-released versions #91

Closed qlands closed 1 year ago

qlands commented 2 years ago

Hi,

@BrandonMrBot and I have discussed the use of R in ClimMob and how we can minimize build problems.

The current line reads:

pkg <- c('caret', 'climatrends', 'ClimMobTools', 'ggparty', 'ggplot2', 'gosset', 
         'gridExtra', 'gtools', 'igraph', 'janitor', 'jsonlite', 'knitr', 'leaflet', 
         'mapview', 'multcompView', 'nasapower', 'partykit', 'patchwork', 
         'PlackettLuce', 'plotrix', 'pls', 'png', 'psychotools', 'qvcalc',
         'remotes', 'rmarkdown')

When we deploy ClimMob this list uses master for ClimMobTools and climatrends. On several occasions, such branches have bugs due to current work.

If it is not possible to set a release tag in pkg <- c() then please freeze/protect the master branch and work on a dev branch. Then after QA make pull requests from dev to master.

Thanks,

kauedesousa commented 2 years ago

Hi @qlands I think the best approach is maybe using only the CRAN versions, as they are stable. I will update the code and avoid fetching versions under development.

What do think?

qlands commented 2 years ago

Hi, yes, particularly for 'climatrends', 'ClimMobTools' if we can fix this call to use a release/stable version

kauedesousa commented 1 year ago

The scripts only calls for packages available on CRAN https://github.com/AgrDataSci/ClimMob-analysis/blob/master/modules/00_check_packages.R