Closed wratte closed 1 year ago
I am trying to create a custom package out of your code changes and use it in my project till an official version is release, but unable to find modules, can you share steps to use this package?
@nikheelneelay What you could do is:
npm install
=> npm run packagr
That will create a dist
folder.
Copy paste the contents of thedist
folder into your node_modules/ngx-material-timerpicker
folder in your actual project. It will prompt you to replace a bunch of files, always replace.
Then run patch-package
: https://github.com/ds300/patch-package
"scripts": {
+ "postinstall": "patch-package"
}
Now everytime you do an npm install
the patch should be applied.
For the ngx-material-timepicker project to build you will need:
I've fixed all problems and updated the spec accordingly. All tests are in green now and this patch is ready to go. I also ran it through travis-ci but unfortunatly the report cannot be uploaded to github for x reason.
@wratte @AgranomVittali Any plan to merge these changes ?
@pranavpandey86 I wish I could but I'm not a contributor. This pull request is ready to go in prod as it passes all test now. @sameer-coditas would it be possible for you to push these changes to the master branch and generate a new version ?
@sameer-coditas if possible , can you please merge this?
@wratte @pranavpandey86 I am not a contributor either.
@pranavpandey86 I have just added a workaround in my project (kind of temporary fix) till the time issue is resolved.
The default numbering system "latn" used to parse the time in locale string returns a Narrow No-Break Space (NNBSP) instead of standard space which cause the parse to fail. The proposed fix replace the NNBSP for a standard space.