search

Agranom / ngx-material-timepicker

Material desing timepicker for Angular 6.0+
https://agranom.github.io/ngx-material-timepicker/
MIT License
342 stars 139 forks source link

NgxMaterialTimepickerModule is not compatible with Angular Ivy #452

Closed sefatanam closed 1 year ago

sefatanam commented 1 year ago

Issue: Error while running Angular v16 app with ngx-material-timepicker due to Angular Ivy incompatibility.

Error Message: The library (ngx-material-timepicker) declaring NgxMaterialTimepickerModule appears to be incompatible with Angular Ivy. This could be resolved by updating to a newer version of the library that supports Ivy. It's advisable to communicate with the library's maintainers about Ivy compatibility.

Request: Kindly ensure Angular Ivy compatibility for NgxMaterialTimepickerModule.

Reproduce: Use NgxMaterialTimepickerModule with Angular v16

My Environment:

Angular CLI: 16.1.8
Node: 16.19.1
Package Manager: npm 8.19.3
OS: win32 x64

Angular: 16.1.8
... animations, cli, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic
... platform-server, router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1502.6
@angular-devkit/build-angular   16.1.8
@angular-devkit/core            15.2.6
@angular-devkit/schematics      16.1.8 (cli-only)
@angular/cdk                    14.2.7
@angular/material               14.2.7
@nguniversal/builders           15.2.1
@nguniversal/express-engine     15.2.1
@schematics/angular             16.1.8 (cli-only)
rxjs                            7.8.0
typescript                      4.9.5
zone.js                         0.13.1
Agranom commented 1 year ago

@sefatanam which version of timepicker do you use?

sefatanam commented 1 year ago

@sefatanam which version of timepicker do you use?

"ngx-material-timepicker": "^5.5.5",
Agranom commented 1 year ago

@sefatanam pls update to the latest version

sefatanam commented 1 year ago

@sefatanam pls update to the latest version

one more thing need to know that is the latest version compatible with Angular Server side rendering?

Agranom commented 1 year ago

@sefatanam I haven't tried it with SSR. I guess the latest version should work

Agranom commented 1 year ago

Let me know if it doesn't

sefatanam commented 1 year ago

Let me know if it doesn't

yeah, sure