Agranom / ngx-material-timepicker

Material desing timepicker for Angular 6.0+
https://agranom.github.io/ngx-material-timepicker/
MIT License
342 stars 139 forks source link

editable dial is not updating when user click on hour and minutes while enableKeyboardInput is true #453

Open venkateshparihar opened 1 year ago

venkateshparihar commented 1 year ago

In ngx-material-timepicker demo page editable dial it working properly but when i implement in my app then editable dial is not updating Please check

proper solution: add set and get for time input on NgxMaterialTimepickerDialControlComponent. so when time changes we can update form control in setter.

Quick fix: update input by classname when the time changes .

Linked of fix: (https://stackblitz.com/edit/angular-ivy-8dy2p2?file=package.json,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fapp.component.html,src%2Findex.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fhello.component.ts)

ngocdu99 commented 1 year ago

@venkateshparihar I encountered the same situation as you, are you waiting for the library to update to fix it or did you fix it yourself.

@Agranom Can you answer it for me?

venkateshparihar commented 1 year ago

@venkateshparihar I encountered the same situation as you, are you waiting for the library to update to fix it or did you fix it yourself.

@Agranom Can you answer it for me? check this example may be this will be helpful for you (https://stackblitz.com/edit/angular-ivy-8dy2p2?file=package.json,src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fapp.component.html,src%2Findex.html,src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fhello.component.ts)

ngocdu99 commented 1 year ago

@venkateshparihar Do you know what version the demo version is? This is demo https://agranom.github.io/ngx-material-timepicker/

venkateshparihar commented 1 year ago

@venkateshparihar Do you know what version the demo version is? This is demo https://agranom.github.io/ngx-material-timepicker/

unfortunately no

DhruvRaiPuri commented 10 months ago

@venkateshparihar - thanks for your workaround - it works well!

Would be better to have a fix for this in library code itself.

arijnr commented 10 months ago

Hi everyone, I created a PR with a fix: https://github.com/Agranom/ngx-material-timepicker/pull/461

pfugiel commented 9 months ago

@arijnr thx. When can we expect new release with this fix?