AgreementMakerLight / AML-Project

AgreementMakerLight Eclipse Project
Apache License 2.0
56 stars 33 forks source link

problem in loading ontologies that have unworking imported ontologies #19

Open marwa811 opened 3 years ago

marwa811 commented 3 years ago

Hello,

Thanks for your effort in such an excellent tool for matching ontologies. I am using your API in my research and I found an exception happened when I try to load an ontology the have a broken imported link. For example, OBOE-SBC.owl (you can download it from Bioportal), has an imported ontology called "oboe-context.owl" that its IRI doesn't exist anymore. That's why when I use your API I got: UnloadableImportException: Could not load imported ontology: http://ecoinformatics.org/oboe/oboe.1.0/oboe-context.owl Could you fix that in your Ontology() class in function openOntology(str,str).

Regards, Marwa

marwa811 commented 3 years ago

P.S. you can use this code snippet for such task:

OWLOntologyManager manager=OWLManager.createOWLOntologyManager(); OWLOntologyLoaderConfiguration loaderConfig = new OWLOntologyLoaderConfiguration() .setMissingImportHandlingStrategy(MissingImportHandlingStrategy.SILENT); IRIDocumentSource source=new IRIDocumentSource(IRI.create("ontology IRI")); OWLOntology ontology = manager.loadOntologyFromOntologyDocument(source, loaderConfig);

DanFaria commented 3 years ago

Hi @marwa811,

I actually made this very fix two months ago in the dev branch we're working on for complex ontology matching, but forgot to update the master branch and the release. I will do so ASAP, and get back to you when it is fixed. Thanks for your appreciation!

Daniel

marwa811 commented 3 years ago

Hi Daniel, I sent you an email 4 months ago to fix the unworking imported ontologies problem. Are you done with it? and if so which version should I use? Appreciated.

Best regards, Marwa

On Tue, Nov 3, 2020 at 1:22 PM Daniel Faria notifications@github.com wrote:

Hi @marwa811 https://github.com/marwa811,

I actually made this very fix two months ago in the dev branch we're working on for complex ontology matching, but forgot to update the master branch and the release. I will do so ASAP, and get back to you when it is fixed. Thanks for your appreciation!

Daniel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AgreementMakerLight/AML-Project/issues/19#issuecomment-721057086, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLV2MVMZNENDRTMWPZJRNLSN7RWNANCNFSM4S53EW5A .

--

Marwa Hussein M. TA @ Information Systems Department Faculty of Computers & Information Assuit University imanhelal@yahoo.com

DanFaria commented 3 years ago

Hi Marwa,

Apologies for the delay. I just fixed the issue. If you were working with the source code, you can just make a new pull of the master branch. If you were working with the binary, please download AML release v3.2.

I would appreciate it if you could confirm that you can load your ontologies with no issues.

Best,

Daniel

marwa811 commented 3 years ago

Hi Dan I am sorry for being late to confirm but I was busy with another project. Now I tried the AML release v3.2. to find if the "could not load imported ontology" Exception, but It was not solved, still getting the same exception!! Any Suggestions to fix it?

Regards, Marwa

DanFaria commented 3 years ago

Hi Marwa,

I'll look further into it to see if there is an alternative fix. But for the time being maybe you can consider the workaround of removing the troublesome import statement(s) from the ontology in question.

Best,

Daniel