AgregoreWeb / agregore-browser

A minimal browser for the distributed web (Desktop version)
https://www.youtube.com/watch?v=TnYKvOQB0ts&list=PL7sG5SCUNyeYx8wnfMOUpsh7rM_g0w_cu&index=14
GNU Affero General Public License v3.0
715 stars 66 forks source link

Agregore using lots of CPU (20%).... an hour or so after I closed it. #175

Closed wolfsprite closed 2 years ago

wolfsprite commented 2 years ago

Summary: Opened Agregore to check a single webpage, closed it shortly after. Agregore still has two processes using 10% CPU each.

(Was checking to see if this browser had Unicode 13.0 support. It does not (🪢), but neither does Opera or Brave, so I'm assuming that's a Chromium thing. I don't believe that to be related to this but idk.)

An hour or so after having closed Agregore, my laptop's fans started to whir while not really doing anything particularly intensive. I opened up Task Manager on Windows 10, sorted by CPU, and Agregore was listed at the top with two processes using about 9-10% CPU each.

My processor is pretty alright and also I had closed Agregore and could confirm that no windows of it were open, so I was concerned and came here to report this issue.

The processes were still running and using 9-10% of my CPU as I was finishing up this post, until I ended them.

image

RangerMauve commented 2 years ago

Thank you for the report!

That's very unexpected. Could you right click the process next time it happens and see if you can get the command line arguments from it?

I think I've heard of something similar happening on Windows before, but I'm not sure what could be causing it.

The process should be quitting on its own whenever you close all the windows: https://github.com/AgregoreWeb/agregore-browser/blob/master/app/main.js#L79

Maybe there's a bug on windows where that event isn't firing and something else is happening?

Did you open any pages with peer to peer protocols like IPFS when you tested this? Does it happen every time you try to run Agregore and close all the windows?

wolfsprite commented 2 years ago

The only page I opened was this one: https://emojipedia.org/knot/ to see if Agregore could render Unicode 13.0 or higher.

I'm actually noticing that Agregore is behaving the same way even if I don't open any webpages, with just agregore://welcome opened, then closing Agregore.. :(

I am unfortunately not seeing any command line arguments in the the details for the processes either, just the path to where the executable is. Not really sure what's going on.

RangerMauve commented 2 years ago

We were doing some debugging in the Agregore matrix channel and my gut feeling is this has got something to do with the old extensions system since it was two "renderer" processes that were left in the background that were taking up a bunch of CPU and memory. My guess is it was the background pages created for the built in web extensions that weren't getting cleaned up on Windows for some reason.

Could a Windows user try out the latest release to see if the issue still happens with it? https://github.com/AgregoreWeb/agregore-browser/releases/tag/v1.0.4 The extension system got overhauled so it likely won't have this issue.

RangerMauve commented 2 years ago

Thanks to b-5 on Matrix, we've confirmed that this has been fixed after updating the extension system in v1.0.4! 🎉🎉🎉

wolfsprite commented 2 years ago

oh that's awesome to know!! thanks to all of y'all and for the update :D