AgregoreWeb / agregore-browser

A minimal browser for the distributed web (Desktop version)
https://www.youtube.com/watch?v=TnYKvOQB0ts&list=PL7sG5SCUNyeYx8wnfMOUpsh7rM_g0w_cu&index=14
GNU Affero General Public License v3.0
715 stars 66 forks source link

URL Bar not showing on MacOS #210

Closed RangerMauve closed 1 year ago

RangerMauve commented 1 year ago

It seems the calculation for the URLbar at the top of windows is being messed up for MacOS.

Specifically, it might be an issue to do with how the bounds for the web content get either calculated or set.

Here is where the bounds get set in the electron side: https://github.com/AgregoreWeb/agregore-browser/blob/master/app/window.js#L377

Here is where we track changes to the web content sizing: https://github.com/AgregoreWeb/agregore-browser/blob/master/app/ui/tracked-box.js

Here is where the bounds get set in the main UI code on getting a resize: https://github.com/AgregoreWeb/agregore-browser/blob/master/app/ui/script.js#L61

It might be that the resize observer isn't being trigger, or there might be some race condition.

It'd be nice if somebody with a mac could try seeing what's going on in here.

RangerMauve commented 1 year ago

This is fixed as of the latest v2.0.0 prerelease 🥳