Add Loading indicator #182 - Githubissues

AgregoreWeb / agregore-browser

A minimal browser for the distributed web (Desktop version)

https://www.youtube.com/watch?v=TnYKvOQB0ts&list=PL7sG5SCUNyeYx8wnfMOUpsh7rM_g0w_cu&index=14

GNU Affero General Public License v3.0

715 stars 66 forks source link

Add Loading indicator #182 #255

Open Arskan17 opened 4 months ago

Arskan17 commented 4 months ago

So.. I tried to do it as suggested in the issue's description, but I don't know how to move forward...

I added the loading attribute in app/ui/omni-box.js, and emit the events from app/window.js, which I then listen for in app/ui/script.js. This then changes the attribute's value to either true or false depending on the event.
I added a random spinning indicator in app/ui/style.css named .spinner.
It's a separate button with its own div id. You can see it in the image attached

loader

The issue is;

I don't know if I'm handling the attributeChangedCallback correctly. I added this.loader = this.$('omni-box-button') and use this.loader.getElementById().classList.toggle() to either make the buttons hidden or visible, but they both stay constantly visible...
I change the value of loading directly in app/ui/script.js when listening for the event, but I'm not sure whether that's even correct, or I should handle it some other way?

Any suggestions on how to move from here ?

Arskan17 commented 4 months ago

Hey @RangerMauve... mind taking a look? Thanks a lot!