search

AgroCares / Open-Bodem-Index-Calculator

An R package containing the functions for the Open Bodem Index (OBI)
https://agrocares.github.io/Open-Bodem-Index-Calculator/
GNU General Public License v3.0
11 stars 2 forks source link

Cran update #190

Closed SvenVw closed 10 months ago

SvenVw commented 11 months ago

The PR contains no changes to the calculations and only contains small fixes for submission

BrentWHR commented 11 months ago

If, according to CRAN, the function examples take too long to run, I think we can add dontrun tags as:

#' @examples
#' \dontrun{
#' 
#' examples go here
#' 
#' }
SvenVw commented 11 months ago

Feedback from CRAN gives still 3 NOTES:

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Check: CRAN incoming feasibility, Result: Note_to_CRAN_maintainers
  Maintainer: 'Sven Verweij <sven.verweij@nmi-agro.nl>'

Flavor: r-devel-linux-x86_64-debian-gcc
Check: examples, Result: NOTE
  Examples with CPU time > 2.5 times elapsed time
                         user system elapsed ratio
  calc_sbal_arable      1.640  0.036   0.190 8.821
  calc_waterstressindex 1.079  0.155   0.219 5.635

Flavor: r-devel-linux-x86_64-debian-gcc
Check: tests, Result: NOTE
    Running 'testthat.R' [62s/8s]
  Running R code in 'testthat.R' had CPU time 7.8 times elapsed time

Flavor: r-devel-linux-x86_64-debian-gcc
Check: re-building of vignette outputs, Result: NOTE
  Re-building vignettes had CPU time 5.4 times elapsed time
SvenVw commented 10 months ago

As this PR does not add new tables or functions to the built R package, it is not expected that the package will grow in size.