search

AgrosupDijon-DSI / moodle-local_ibob

Cnerta-Web Plugin iBob pour Moodle
Other
0 stars 0 forks source link

mix of inline php and functions in the same files. #10

Open danmarsden opened 6 months ago

danmarsden commented 6 months ago

https://github.com/AgrosupDijon-DSI/moodle-local_ibob/blob/main/local/ibob/emailconfirmation.php#L105

These function names violate our naming conventions (see: https://moodledev.io/general/development/policies/codingstyle/frankenstyle#function-names)

but the files shouldn't mix inline php code and functions.

functions should be in a standalone file like lib.php or locallib.php or in namespaced classes within the classes folder.

note this is a blocker for plugins db approval.

danmarsden commented 6 months ago

along those same lines - function names like "get_user_providers" in yoru lib.php are not allowed: https://github.com/AgrosupDijon-DSI/moodle-local_ibob/blob/main/local/ibob/lib.php#L53

all functions in that file should be prefixed with "local_ibob"