AgrosupDijon-DSI / moodle-local_ibob

Cnerta-Web Plugin iBob pour Moodle
Other
0 stars 0 forks source link

missing security checks in external service. #9

Open danmarsden opened 6 months ago

danmarsden commented 6 months ago

in the definition you state that login is required here: https://github.com/AgrosupDijon-DSI/moodle-local_ibob/blob/main/local/ibob/db/services.php#L34

but you don't actually make the correct security checks inside your function: https://github.com/AgrosupDijon-DSI/moodle-local_ibob/blob/main/local/ibob/externallib.php#L60

Please see the developer docs here for the correct security checks that should be implemented: https://moodledev.io/docs/apis/subsystems/external/writing-a-service#context-and-capability-checks