Add message for failed unittests.

Agrover112 / fliscopt

Algorithms for flight scheduling optimization.

https://pypi.org/project/fliscopt/

MIT License

39 stars 12 forks source link

Add message for failed unittests. #35

Closed Agrover112 closed 3 years ago

Agrover112 commented 3 years ago

A message indicating a failure for each unit-test, should give the user a small idea of what went wrong in the test. ex: self.assertEqual ( f(values), 0, msg ='HEURISTIC MESSAGE INDICATING WHY TEST CASE FAILED')

Yoda-Canada commented 3 years ago

can I work on this issue?

Agrover112 commented 3 years ago

can I work on this issue?

Sure !

Yoda-Canada commented 3 years ago

@Agrover112 I run the example1.py, and the terminal cannot find the flights.txt. I checked the flights.txt and it had been saved in the data folder. Could you help me ? 1634600630(1)

Agrover112 commented 3 years ago

@Agrover112 I run the example1.py, and the terminal cannot find the flights.txt. I checked the flights.txt and it had been saved in the data folder. Could you help me ?

Sure.

Agrover112 commented 3 years ago

@Yoda-Canada It's in the README.md in getting started! as link

Yoda-Canada commented 3 years ago

I have already done all steps which are in getting started, but the terminal cannot find it.

1634601434(1)

Yoda-Canada commented 3 years ago

@Agrover112 , It's ready to run， thx.

Yoda-Canada commented 3 years ago

@Agrover112 Question 1: I want to make sure that only these three files (test_algorithms.py, test_chaining.py, test_fitness.py) are needed to add error messages, right? 1634660682(1) Question 2: There are only "self.assertEqual()" and "self.assertIsNotNone()" in the test files. "self.assertIsNotNone()" already has error message in it's definition. Do I just need to add error message to "self.assertEqual()"? 1634661217(1)

@Yoda-Canada Refer your master branch I made some changes there.

Agrover112 commented 3 years ago

@Yoda-Canada So I raised a PR to YOUR fork. Accept that PR and make further changes. Also do this asap, since I do not want your fork to fall behind the master branch again :( Also maybe if interested at a later date you could check out #42 (similar but might take up huge amount of time on hold for rn)

Yoda-Canada commented 3 years ago

@Yoda-Canada So I raised a PR to YOUR fork. Accept that PR and make further changes. Also do this asap, since I do not want your fork to fall behind the master branch again :( Also maybe if interested at a later date you could check out #42 (similar but might take up huge amount of time on hold for rn)

@Agrover112 no worry I will do it ASAP.

Agrover112 commented 3 years ago

@Yoda-Canada So I raised a PR to YOUR fork. Accept that PR and make further changes. Also do this asap, since I do not want your fork to fall behind the master branch again :( Also maybe if interested at a later date you could check out #42 (similar but might take up huge amount of time on hold for rn)

@Agrover112 no worry I will do it ASAP.

I'm awake for your bro :)

Yoda-Canada commented 3 years ago

@Agrover112 I have created a PR 48, please review it, thx.