search

AguaClara / SWOT

CEE 4520 course material
MIT License
17 stars 8 forks source link

Questions on Code #173

Closed Kyddyl closed 1 year ago

Kyddyl commented 1 year ago

Our code only gives us values up until our 5th question. How would we be able to fix that? We are also trying to figure out how we could use the printmap function to pull up the parts list.

https://cad.onshape.com/documents/8511d21835ac40f251b92203/w/1ab2bfe53e4b4beefa618b19/e/3c45f151e8ca087874203c35

Squilliam314 commented 1 year ago

I agree, I have this issue as well

clare45 commented 1 year ago

It looks like there is a unit error that is stopping the code from working all the way through, your answer for Q4 (should be an area) has units of meters^3 per second .

I recommend printing all your variable to see which one gets you a weird unit and then investigating that.

Kyddyl commented 1 year ago

How would I be able to fix that? Or change the units for that? Because I think it should work out by that division. Unless there is something set with the wrong units

Kyddyl commented 1 year ago

image

clare45 commented 1 year ago

It is possible that one of the parameters has units that it shouldn't have, once you know which variable is causing the issue that should narrow it down a bit

Kyddyl commented 1 year ago

I am also getting this error

Kyddyl commented 1 year ago

I think the problem is that trashrack_Vmin doesn't have units, because it is just taking Qm_max units

clare45 commented 1 year ago

If you rename to "trashrack_V_min" does that help?

Kyddyl commented 1 year ago

Yeah it worked! Thank you! I am sorry but now I am getting an error for number 7. I am not sure why it is not adding up

clare45 commented 1 year ago

I am not actually sure why that worked, but am glad it did.

Likely also a units thing, are both terms actually in meters?

Kyddyl commented 1 year ago

I think the design FB should be in meters, I am not sure why it would not be. Unless I did something wrong

Kyddyl commented 1 year ago

Could it be that, Since it is choosing between three values?

Kyddyl commented 1 year ago

Hi Clare,

Is this everything we need? Are we missing something

clare45 commented 1 year ago

It looks like it is working now?

Be sure you are adding the right value with the freeboard though. Does the trash rack always set the height of the water? If not, what other variable should be included there.

Kyddyl commented 1 year ago

It should be the maximum so it should just be height of the water

Kyddyl commented 1 year ago

I think that is all we have to do? if that is that, I am thankful for you helping

Kyddyl commented 1 year ago

help*