Closed IanCullings closed 6 years ago
I will grade it today! Technically there is no minor loss for a straight pipe. If you use the head loss trick, then yes the minor loss coefficient for a straight pipe becomes 1!
Your report was good! Buuuuuut I have some (ok a lot) of comments.
While reading this report, I kept coming back to the same idea: Your audience is AguaClarians who have never been on the UASB team before. They need to be able to look back at what you guys are doing through this report and understand perfectly and what you guys did and why you did it. If you leave the UASB team after one semester, one year, or two years, all of your work will be lost unless you document it well and perfectly clearly. I know that documenting isn't very exciting, but I also know that unless you document as you go, there is a 0% chance you'll look back on your work 2 months ago and say: "Hey, I really want to retroactively document what I did then!"
So respect your own time and use some of it to write great reports! I know it's hard to get out of your own head when writing, so have your STEM friends who don't know anything about your work read it and tell you where they get confused. Most importantly, spend the time that you need to write an amazing report. It is always worth it.
Also: Your python code does not print to GitHub, I recommend writing what your answer should be in a comment at the end of your code block!
Also also: I think you will find this function in aide_design helpful, it returns a circle's area given its diameter.
Also also also: Your headings are not very well organized. Everything seems rather thrown together as it's needed. I would consider reorganizing/using a table of contents.
Here we go. Because my comments are based on line numbers, it's best to edit them in-situ and check off all the ones that don't require adding additional lines first. Then, work your way up from the bottom. If you're planning on restructuring the document, I would first implement any of my changes that you would like and then restructuring, so that the line numbers are not lost. Finally, check off boxes for finished items as you go!
I am very sorry for the extreme length of this document. Happy Monday and see you next week!
GOD DAMMIT JUAN.
I'm jk thank you for spending so much time!
Yo @juanchon998 Clare here. The "head loss trick" is confusing if thought of as an "exit loss" because that suggests a minor loss (at least to me). I think we need to call this something different still, because it's confusing. Why not say simplified energy equation or difference in elevation head. (I've also never heard of it called a trick so i'm totally down to change the verbiage in the book)
Yo @clare45 I don't think that "simplified energy equation" or "difference in elevation head" convey the same meaning. Perhaps when it first comes up, we could declare it convention to simply link to the textbook where the head loss trick is explained, and then take it as a given for the rest of the report? That's my initial though
So @juanchon998, do you suggest that we should refer to it in the report still as "head loss trick" but embed a link to the textbook?
As of now I would recommend referring to it once as "head loss trick," linking it to the textbook, and saying that it will be used throughout the rest of the document (then not mentioning it again). Basically I want it to be clear to the reader that we are using the head loss trick while also minimizing the uses of the the phrase "head loss trick." If you come up with another way of accomplishing that then definitely use that!
More edits before the end of the summer:
More tasks:
TASKS FOR FINAL SUMMER REPORT Ian
Hey @juanchon998 our research report is linked below, thanks again for editing it. One area that would be great for you to look over is the functions (do they make sense, should we add more).
Here it is
Also a random fluids question, but the minor loss coefficient for a straight pipe is just 1, right?