search

AguaClara / aguaclara

An open-source Python package for designing and performing research on AguaClara water treatment plants.
https://aguaclara.github.io/aguaclara/
MIT License
24 stars 13 forks source link

list handler wrapper missing from vertical orifice and horizontal orifice functions #137

Closed monroews closed 5 years ago

monroews commented 5 years ago

Vertical and horizontal orifice flow rates in physchem had a list_handler(HandlerResult="nparray"): wrapper that enabled them to handle arrays. That list handler is missing and because of that the functions can't handle arrays. This lost capability was needed for CEE 4520. I'm working on the design challenges for that course and am wondering if this capability can be restored or if there was a reason why this feature was not kept.

The list handler is in utilities.

fletchapin commented 5 years ago

@monroews This was removed when I found out ut.list_handler was breaking all our tests. Once I fixed the function I believe it should have been added back to all the functions, but this one was probably missed.

More details: https://github.com/AguaClara/aguaclara/issues/99

fletchapin commented 5 years ago

@oliver-leung I believe the function is fixed so the wrappers can be added back. Could you check that the tests pass when the wrapper is re-added to physchem?

fletchapin commented 5 years ago

I've gone ahead and added these back on my branch (fletch/miscFixes), but I didn't have time to test.

@monroews could you please test off this branch? I made a number of small changes and don't have the time to test them near thoroughly enough.

monroews commented 5 years ago

Perhaps @oliver-leung could test this. I won't have time this spring...