search

AguaClara / aguaclara

An open-source Python package for designing and performing research on AguaClara water treatment plants.
https://aguaclara.github.io/aguaclara/
MIT License
25 stars 13 forks source link

Upgrade Pint version #284

Closed HannahSi closed 4 years ago

HannahSi commented 4 years ago

Resolves #271: The Pint package version was fixed at version 0.8.1 to solve issue #155. However, the problem in the issue no longer occurs with the latest versions of Pint and the aguaclara package, and fixing the version has caused problems with loading the aguaclara package in Google Colab and parsing Onshape variables. In this PR, Pint is upgraded to the latest version. A few test files and doctests were modified to prevent round-off errors.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0a774df). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #284   +/-   ##
=========================================
  Coverage          ?   90.58%           
=========================================
  Files             ?       49           
  Lines             ?     3804           
  Branches          ?        0           
=========================================
  Hits              ?     3446           
  Misses            ?      358           
  Partials          ?        0
Impacted Files Coverage Δ
aguaclara/design/ent_floc.py 100.00% <ø> (ø)
aguaclara/design/floc.py 88.57% <ø> (ø)
aguaclara/design/sed_chan.py 100.00% <ø> (ø)
aguaclara/design/sed_tank.py 96.03% <ø> (ø)
aguaclara/research/stock_qc.py 100.00% <ø> (ø)
tests/core/test_physchem.py 99.82% <100.00%> (ø)
tests/core/test_utility.py 100.00% <100.00%> (ø)
tests/design/test_floc.py 100.00% <100.00%> (ø)
aguaclara/__init__.py 100.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a774df...aa80613. Read the comment docs.