AguaClara / aguaclara_research

a python package containing research tools for AguaClara
MIT License
1 stars 4 forks source link

General Recommendations for ProCoDA_Parser.py #7

Closed WPennock closed 6 years ago

WPennock commented 6 years ago

Based on my quick glance at the last two functions in ProCoDA_Parser.py, here are a few features I think might be good to add:

Great work, Fletcher! I'm very excited by the promise of this module!

fletchapin commented 6 years ago

@WPennock Good suggestions! I'll start to work on them soon. I'll create a new branch as well, since we should start to work using version branches and then merging into master rather than editing master directly

fletchapin commented 6 years ago

Also @WPennock the input for individual ProCoDA files is the original .xls file, and those are tab delimited.

I'm not sure how to ensure that .xls files are tab delimited, but that's necessary for the read_csv function to work properly.

fletchapin commented 6 years ago

@WPennock these have been addressed in the new branch I made, procoda_parser, and it'd be great if you could test them out