AguaClara / aide

AguaClara Infrastructure Design Engine - a software tool that designs AguaClara water treatment plants and their components.
MIT License
0 stars 0 forks source link

Pipe library and database integration #51

Open monroews opened 3 years ago

monroews commented 3 years ago

The feature script pipe database and the part studio pipe library should get their data from a single source. I really like the idea of having a pipe data base in a CSV file. That database could presumably be used to by the pipe library for drawing pipes and could be accessed by featurescript for getting dimensions needed for design. This would be more elegant than using superderive to access the pipe library to extract a pipe dimension. Here is a nice data source https://www.gfps.com/country_US/en_US/lightbox/pvc-cpvc-tech/metric/metric-dimensions.html. The research IT team is currently working to create a pipe class in python. We could use a common data source for both python and FS. There are two approaches to obtaining all of the pipe dimensions. One approach is to use equations to define the ID (based on SDR) and the other approach is to include the ID in the database. One reason to include the ID in the database is that the actual IDs are less than that calculated using SDR because the SDR specifies a minimum wall thickness. If we move to a CSV for the data source then the ID for SDR pipes should be in the csv file rather than calculated.

fletchapin commented 3 years ago

@ethan92429 would you say this is complete now that the new Pipeline feature is finished?