AguaClara / aide

AguaClara Infrastructure Design Engine - a software tool that designs AguaClara water treatment plants and their components.
MIT License
0 stars 0 forks source link

Fabrication details for the doser #59

Open monroews opened 3 years ago

monroews commented 3 years ago

The doser lever system and sliders does not yet include the details of fasteners to clearly show which connections are fixed and which allow rotation. Add these part details using the same system that is being used for the pipeline so that the parts list for the doser is complete and the drawing is correct.

oliver-leung commented 3 years ago

@monroews The link you sent is broken - are you referring to this new CDC document?

@pgr38 @cshi15

monroews commented 3 years ago

Yes! I moved the smart components into independent files.

I'd prefer if each group created branches on this file so we don't clash in the design process.

pgr38 commented 3 years ago

@monroews By fasteners do you mean the nuts/bolts/washers on the lever arm? If so, what do you mean by adding these to the lever arm model "using the same system that is being used for the pipeline"?

monroews commented 3 years ago

Yes, the nuts/bolts/washers. There must be clear indication of how parts that can swivel can have fasteners that are tight and locked in place while the part still swivels. The method for adding fasteners is a question for @oliver-leung and @ethan92429 too. The idea is to add the McMaster part numbers to the part descriptions. You can see the results of this when you use the pipeline feature. The other key idea is that the parts should NOT be imported cad drawings with threads, etc because that will slow the Onshape rendering process. Instead the drawn part has just enough detail to represent the important geometry and the rest of the info is in the part number.

oliver-leung commented 3 years ago

For now, we'll be labelling the fastener parts directly with this information, but in the future, we can make a custom feature type that can automatically populate the part description the same way that Pipeline does. I'll open a new issue for the generalized case.