AguaClara / humic_acid

Investigate the optimal coagulant dosage at different humic acid concentrations
1 stars 11 forks source link

Github Issues Check #3 #25

Closed caching13 closed 6 years ago

caching13 commented 6 years ago

See the rubric that was shared with you earlier in the semester for your Team's grade.

-Limited progress since the last Issues check? -Please document discussions, setbacks. It is difficult to determine if the team has an any progress since the last check.

My comments from the previous Issues check still stand. I do not deduct a significant amount of points the first time I suggest improvements, but in subsequent checks (like this one) I do because I am addressing the same issues as before. -Can better incorporate experimental data (graphs/results) of findings instead of just stating the conclusion that was made from the experimental data? -There are generally a lot of Issues still open: is there a better way to organize these within each Issue (what the conclusions were?) as well as overall (each Issue contributes to a larger idea/topic, a suggestion would be to use labels to categorize Issues)

-Next Issues check will be in 2 weeks! -Feel free to contact me with questions!

VanessaQi commented 6 years ago

Hi Casey, Thanks for the comment. When we try to copy/paste our experimental graphs, it seems like the github doesn't allow us to do so. As we have stored all our labeled graphs/data in the google drive folder, is that okay that we just put the link below so you could check them? Or I could also upload the graph as a file at the comment section.

caching13 commented 6 years ago

Hi Vanessa and Team,

Please attach the labeled graphs/data in Github by uploading it as a file in the comment section! Having some textual context alongside the data is also encouraged, so that anyone who reads that Issue will understand 1) Why the experiment was run, 2) What the hypothesis was, and whether it was proven/disproven, and 3) Steps moving forward with the data.

Just a reminder, it is encouraged that all team members help with uploading and adding textual context.

At any time, please let me know if there are any questions moving forward!

VanessaQi commented 6 years ago

Okay! Will do so!