search

AguaClara / post.visualize.angular-DEPRECATED

Apache License 2.0
0 stars 1 forks source link

Reviewing last semester code #1

Open eak24 opened 6 years ago

eak24 commented 6 years ago

I'm looking through what was done last semester. I'll make comments here.

eak24 commented 6 years ago

I can't review this until it is actually building. @GPacenza have you had this master branch working the way it is? I get the following errors:

ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (9,40): Cannot find name 'OnInit'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/graph.component.ts (2,21): Cannot find module 'd3-selection'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/graph.component.ts (4,26): Cannot find module 'd3-shape'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/graph.component.ts (5,26): Cannot find module 'd3-array'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/graph.component.ts (6,25): Cannot find module 'd3-axis'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/graph.component.ts (8,23): Cannot find module './shared/data'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (11,40): Cannot find name 'OnInit'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (15,29): Property 'chrome' does not exist on type 'Window'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (15,48): Property 'chrome' does not exist on type 'Window'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (24,5): Cannot find name '$'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (25,9): Cannot find name 'addSpinner'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (26,3): Cannot find name 'updatePlantData'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (26,19): Cannot find name 'visualize'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (29,5): Cannot find name '$'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (30,9): Cannot find name 'addSpinner'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (31,9): Cannot find name 'updatePlantData'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (31,25): Cannot find name 'settable'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (37,9): Cannot find name 'connectSyncButton'. Did you mean the instance member 'this.connectSyncButton'?
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (38,8): Cannot find name 'addSpinner'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (39,9): Cannot find name 'updatePlantData'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/plant.component.ts (39,25): Cannot find name 'visualize'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (10,5): Unexpected token. A constructor, method, accessor, or property was expected.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (46,29): ';' expected.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (147,1): Declaration or statement expected.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/graph.component.ts (3,26): Cannot find module 'd3-scale'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (25,14): Cannot find name 'd3'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (28,5): Cannot find name 'table1Dict'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (38,5): Cannot find name 'table2Dict'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (46,5): Cannot find name 'settable'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (46,14): Cannot find name 'data'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (46,20): Cannot find name 'codeList'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (48,7): Cannot find name '$'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (49,7): Cannot find name '$'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (51,23): Cannot find name 'data'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (54,32): Cannot find name 'table1Dict'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (55,33): Cannot find name 'table2Dict'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (60,19): Cannot find name 'd3'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (66,20): Cannot find name 'd3'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (72,19): Cannot find name 'd3'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (89,32): Cannot find name 'table1Dict'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (93,33): Cannot find name 'table2Dict'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (139,5): Cannot find name '$'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (140,7): Cannot find name 'connectSyncButton'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (142,7): Cannot find name 'data'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (142,14): Cannot find name 'retrieveAllPlantData'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (143,11): Cannot find name 'data'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (144,9): Cannot find name 'settable'.
ERROR in /Users/ethankeller/git_repos/AguaClara/post.visualize.angular/src/app/table.component.ts (144,18): Cannot find name 'data'.
GPacenza commented 6 years ago

No we've not got the master branch to work as it is yet, we still have to deal with those errors as well.