Aguafrommars / TheIdServer

OpenID/Connect, OAuth2, WS-Federation and SAML 2.0 server based on Duende IdentityServer and ITFoxtec Identity SAML 2.0 with its admin UI
https://theidserver-duende.herokuapp.com/
Apache License 2.0
698 stars 83 forks source link

8.1 preview #1286

Closed aguacongas closed 4 weeks ago

gitguardian[bot] commented 4 weeks ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [3847611](https://dashboard.gitguardian.com/workspace/223586/incidents/3847611?occurrence=126590231) | Triggered | Generic Password | f412a2b39e831bd9f0a61424c7059f7e3c46ebaa | src/IdentityServer/Migrations/Aguacongas.TheIdServer.Oracle.Startup/appsettings.json | [View secret](https://github.com/Aguafrommars/TheIdServer/commit/f412a2b39e831bd9f0a61424c7059f7e3c46ebaa#diff-3bea21b2458bcf65b55884d9096fbcf25adf46b9e3c851570d9894864c9b4833L3) | | [3847611](https://dashboard.gitguardian.com/workspace/223586/incidents/3847611?occurrence=126584532) | Triggered | Generic Password | 3db29b10fd9d1b6314ddf865175388cd55e185c1 | src/IdentityServer/Migrations/Aguacongas.TheIdServer.Oracle.Startup/appsettings.json | [View secret](https://github.com/Aguafrommars/TheIdServer/commit/3db29b10fd9d1b6314ddf865175388cd55e185c1#diff-3bea21b2458bcf65b55884d9096fbcf25adf46b9e3c851570d9894864c9b4833L3) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

sonarcloud[bot] commented 4 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
78.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

AppVeyorBot commented 4 weeks ago

:white_check_mark: Build TheIdServer 8.0.2-56.build.3881 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/0e3ceead08 by @aguacongas)