search

AgustinBonilla / ConfigPlugin

Config plugin to Xamarin applications.
16 stars 6 forks source link

Add .Net Standard support #3

Closed dkornev closed 3 years ago

dkornev commented 6 years ago

We should port the library to dotnet standard so we can use it for the modern xamarin net standard approach.

dkornev commented 6 years ago

@AgustinBonilla Please assign it to me, I'll do it if you don't mind

AgustinBonilla commented 6 years ago

Hello Denis, adding support for .NET standard is a task that could not be done because I'm very busy, but I have it in the plans for this add-on. I added you as a collaborator, I do not know if you can modify the code to generate a new version. Any comments or suggestions you have are welcome. Regards, Agustin.

dkornev commented 6 years ago

Hi @AgustinBonilla, I'm going to work on that these weekends

dkornev commented 6 years ago

Pull request created #4

prof79 commented 6 years ago

Since the issue is still open though committed I'd like to use this opportunity to ask a question:

Why are you specifically targeting .NET Standard 2.0? I just tried to compile the code, it is so lightweight and independent you could go as low as .NET Standard 1.0! And it would be consumable by so much more projects! This would also conform to the Xamarin University guidance to go as low as your API requirements allow it. And it can be used by any .NET Standard project targeting the same version or HIGHER.

I also have a concrete use case for myself: I'm still using a Lumia 950 (Windows 10 Mobile) which is 10.0.15254 (10586 level) so the constraints are Xamarin.Forms 2.5.1 and .NET Standard 1.4 at the highest. I can use anything <= .NET Standard 1.4 or equivalent PCL in such a project.

https://elearning.xamarin.com/forms/xam110/netstandard/netstandard-versions has a good API changes overview.

prof79 commented 6 years ago

And btw you could also get totally rid of the .nuspec file - in case you don't need it elsewhere - because .NET Standard project format in VS/dotnet core has package properties support and can directly build packages in one go with compilation; or, as an alternative, manual build with the dotnet pack command.

dkornev commented 3 years ago

Closing due to inactivity.