search

AgustinCB / docker-api

Docker Remote API driver for node.js. It uses the same modem than dockerode, but the interface is promisified and with a fancier syntax.
GNU General Public License v3.0
303 stars 51 forks source link

Correct return types of Object to Stream #50

Closed sabrehagen closed 5 years ago

sabrehagen commented 6 years ago

It seems Object has been used for generic responses, when really they should be of type Stream

AgustinCB commented 6 years ago

I love it. There's a problem in the test that's also affecting another PR. I hadn't time yet to look at that, but will do and merge this.

Thank you so much, I appreciate this fix. Yay type safety!

sabrehagen commented 6 years ago

Great, thank you!

sabrehagen commented 6 years ago

I fixed the build - that was my error.