Open wclr opened 5 years ago
You're right. When I did this project, I was just starting with Typescript and missed a lot of things. I'd like to fix this, but I can't promise an ETA because I have other projects on the go.
That being said, contributions are welcomed.
I'm also here in the search for proper types.
It should be easy though. you could just add @types/dockerode
as a dependency and just re-use them.
Types are somewhat up to date: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/dockerode/index.d.ts
You are writing with TS, and still typing seems to be not good, even
@types/dockernode
feel to have more proper typings.Even your
new Docker(/*opts: not typed*/)
constructor has no typings for options, and results are typed not correctly:It is not a critique, just want to draw your attention to typings issues.