Change HTTP to HTTPS - Githubissues

AgustinSRG / Pokemon-Showdown-Node-Bot

Pokemon Showdown Bot for Node (Deprecated)

Other

34 stars 150 forks source link

Change HTTP to HTTPS #68

Open CharizardtheFireMage opened 7 years ago

CharizardtheFireMage commented 7 years ago

Whenever I add a team with this bot, I check if the team copied into the bot's teams.json but whenever I view the JSON file, the team that I had uploaded into the bot's team database via .teams add, [name], [tier], [hastebin link] didn't copy the team at all. When I had a look between hastebin and features-battle.js, I had found out that the file rather uses http than https as hastebin is linked as [https://hastebin.com/]. Hence, why I am sending a pull request to fix this error in adding teams.

Lord-Haji commented 7 years ago

PR naming should be like Hastebin: Use SSL URL @CharizardtheFireMage

Lord-Haji commented 7 years ago

Side Note: If you are doing this

Check https://github.com/Ecuacion/Pokemon-Showdown-Node-Bot/blob/master/features/battle/README.md#battle-commands There is a hastebin URL having http Line 32 in Raw MarkDown

Lord-Haji commented 7 years ago

This PR and #63 should close #61 @asanrom

Mystifi commented 7 years ago

Note that this isn't main, @Lord-Haji, and that while clearer PR names are preferred, it's not as necessary since @CharizardtheFireMage provided a detailed commit description

Lord-Haji commented 7 years ago

Thats sorta true @Mystifi

jaredgrady commented 7 years ago

apparently i made a duplicate pr to fix this. Imma bump this and close out mine.

DeathlyPlays commented 7 years ago

@CharizardtheFireMage I added your changes to my bot, and it worked as seen on http://replay.pokemonshowdown.com/exiled-gen7ou-800 thanks, hope you don't mind me adding these changes on my github and I plan to continue Ecuacion's bot work