websocket 1.0.18 does not work with node 10.0.0

AgustinSRG / Pokemon-Showdown-Node-Bot

Pokemon Showdown Bot for Node (Deprecated)

Other

34 stars 150 forks source link

websocket 1.0.18 does not work with node 10.0.0 #72

Open Hidden50 opened 6 years ago

Hidden50 commented 6 years ago

https://github.com/theturtle32/WebSocket-Node/issues/315

The 1.0.18 version used in this project's package.json does not work with node 10.0.0. This is fixed by websocket 1.0.26.

I'm not sure if updating to that version would make any breaking changes, so I'm creating an issue rather than a pull request.

Mystifi commented 6 years ago

This repository has been dead for over a year, so I'm honestly not sure how quickly this will be seen by people. As far as what's in the repository's package.json and ChangeLog, the minimum Node requirements seem to align (and no breaking changes seem to have been listed), so I don't think a pull request should harm anything.