AhKi / oh-my-desk

web widget desktop application
GNU General Public License v3.0
75 stars 11 forks source link

Use site's favicon and title in Window's Taskbar #169

Closed keith0305 closed 5 years ago

keith0305 commented 5 years ago

Do you want to request a feature or report a bug? feature

What is the current behavior? Window's title and icon is always oh-my-desk's default (oh my desk's logo with title "Oh_My_Desk")

Expected behavior Favicon of the widget's site and of the site</p> <p><strong>URL attempting to access</strong> Any site</p> <p><strong>Screenshots (Optional But May Be Requested)</strong> <img referrerpolicy="no-referrer" src="https://user-images.githubusercontent.com/5112337/53796776-c6c17e00-3f6f-11e9-9e7d-7d1b5007fa7e.png" alt="image" /></p> <p><strong>Oh-My-Desk Version:</strong> 2.0.3</p> <p><strong>OS / OS Version:</strong> Windows 10</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HyunmoAhn"><img src="https://avatars.githubusercontent.com/u/23732795?v=4" />HyunmoAhn</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>Sorry for late on leave a comment. <del>Why didn't mail notify me?</del></p> <p>You're right. I will fix it. <del>Maybe I need some time.</del> Thank you!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HyunmoAhn"><img src="https://avatars.githubusercontent.com/u/23732795?v=4" />HyunmoAhn</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>I will update your opinion partly.</p> <p>I can change <code>taskbar of windowOS</code> title each other. It will be released after update.</p> <p>But, I need to more information about convert favicon. I can get favicon of each web-site. But I don't know update <code>taskbar of window OS</code>. I tried <code>browserWindow.setIcon</code> or <code>browserWindow.setOverlayIcon</code> but It doesn't solution. 😢 </p> <p>In short, I will update that change title of widget but not favicon. Thank you for suggestion and waiting update. Need to some time to release.</p> <p>It is screen shot that changed by url</p> <p><img src="https://user-images.githubusercontent.com/23732795/56109253-adf2b200-5f8a-11e9-806e-5311c038c262.png" alt="image" /></p> <p>I temporary close this issue. I will open when can progress about favicon.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>