search

Aharoni-Lab / Miniscope-DAQ-Cypress-firmware

DAQ firmware for V3 and V4 Miniscope platforms
15 stars 8 forks source link

Some maintenance tasks & code reformatting #11

Closed ximion closed 1 year ago

ximion commented 1 year ago

Hi Daniel! I am currently working on making the BNO work on Linux OSes, which unfortunately is quite a bit more involved (it again boils down to Windows allowing things that the USB UVC specification forbids, and Linux ensuring "sane" behavior, while Windows doesn't seem to care. Good for regular cameras, bad for us with the somewhat special implementation that the Miniscope uses).

The firmware code was extremely hard to work with though, due to mixing tabs & spaces, different formatting styles, varying alignment, varying brace styles etc., so I bit the bullet this time and reformatted it using clang-format. I tried to stay as close as possible to the original coding style, and excluded the Cypress files from being formatted in order to reduce noise (and to allow easier future updates in case we need to update the files).

This PR does not change any logic, it is purely housekeeping work to prepare for future changes. It is quite invasive in terms of lines of code touched, so I hope this is acceptable for you.

Thank you for considering! Cheers, Matthias

ximion commented 1 year ago

@daharoni Can you have a look if this change is okay? It's mainly cosmetic, but a prerequisite for another change that I'd like to submit and that builds upon this.

daharoni commented 1 year ago

Thanks for this @ximion!

ximion commented 1 year ago

Awesome, thank you! That made implementing https://github.com/Aharoni-Lab/Miniscope-DAQ-Cypress-firmware/pull/12 so much easier! :-D