Aharoni-Lab / miniscope-io

Data formatting, reading, and writing from miniscopes
https://miniscope-io.readthedocs.io
GNU Affero General Public License v3.0
6 stars 2 forks source link

Performance improvement for StreamDaq #29

Closed t-sasatani closed 1 month ago

t-sasatani commented 2 months ago

Performance improvement for StreamDaq (updates by @sneakers-the-rat and @t-sasatani ; based on #27 )

I confirmed on HW that this runs real-time for small 200 px * 200 px, 20 FPS videos. Ideally, we'd want to make the HW capture interface the only external process, but I don't have time to work on it this week, and I guess this isn't mandatory, so I opened a PR at this point.

sneakers-the-rat commented 2 months ago

I like it. Lemme dig deeper into this in a bit :)

sneakers-the-rat commented 2 months ago

have to run right now, but did a refactor of the cli stuff so it's like

mio stream capture --help
mio stream test --help

and made some quick things for DRY there so we have room for expansion (i'm anticipating we'll want something like mio stream configure and whatnot so making room for future nested commands for the streamdaq)

coveralls commented 2 months ago

Coverage Status

coverage: 71.902% (+2.6%) from 69.347% when pulling 811562a414e155a9855c2c1285110ae21abac3be on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

sneakers-the-rat commented 2 months ago

one more thing - since we're adding the cli here, i went ahead and removed the old streamDaq entrypoint and the ability to call it as a module with a deprecation warning. that's another thing we will work on in the future is deprecations, but since we're still in alpha and there is literally zero expectation of a stable API for now, we're good.

coveralls commented 2 months ago

Coverage Status

coverage: 72.18% (+2.8%) from 69.347% when pulling a01ea979ff50dfe2da0a19291a6771c9ea39c08e on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

sneakers-the-rat commented 2 months ago

forgive me as i re-run tests and mess with coveralls configuration settings

coveralls commented 1 month ago

Coverage Status

coverage: 72.788% (+3.4%) from 69.347% when pulling e340d5f27f87c0c9fce033d1dc957afe74f623db on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

t-sasatani commented 1 month ago

I just unchecked this option because re-reviewing every minor commit feels unnecessary. So, I might force merge this one since it's already reviewed once.

Dismiss stale pull request approvals when new commits are pushed

I'm also fine moving back, so please let me know if you'd like to revert this. @sneakers-the-rat

coveralls commented 1 month ago

Coverage Status

coverage: 72.027% (+2.7%) from 69.347% when pulling 6193e3b084d7a77884a12e4044da5bb50c2a8892 on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

sneakers-the-rat commented 1 month ago

Agreed. Since its just the two of us anyway it was a bit much

coveralls commented 1 month ago

Coverage Status

coverage: 61.868% (-7.5%) from 69.347% when pulling 70fe6a52e0acb31dd19ddbbf59126ab3363be63c on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

coveralls commented 1 month ago

Coverage Status

coverage: 71.973% (+2.6%) from 69.347% when pulling 1be04796740a57676767b2a669b1e15079eb2e8f on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

coveralls commented 1 month ago

Coverage Status

coverage: 72.069% (+2.7%) from 69.347% when pulling 3cc16d0acf630266b5f36e37c24779229aae6a38 on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

coveralls commented 1 month ago

Coverage Status

coverage: 71.973% (+2.6%) from 69.347% when pulling e08a80a8c4d5eb778a286a7f471cac96fdcb6a7e on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

coveralls commented 1 month ago

Coverage Status

coverage: 71.973% (+2.6%) from 69.347% when pulling 5ba9ebace3974c470e70126120f33415736fb19d on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

coveralls commented 1 month ago

Coverage Status

coverage: 72.069% (+2.7%) from 69.347% when pulling 9c7dc917bec1d0ecfeea8e56052653eb3bf256b0 on perf-streamdaq into e4e1c0bee845a3c157f666cd1eecd14efe023fb3 on main.

t-sasatani commented 1 month ago

Ok, I'm going to merge this now. Quite a few updates. Thanks for your help, @sneakers-the-rat !