Aharoni-Lab / miniscope-io

Data formatting, reading, and writing from miniscopes
https://miniscope-io.readthedocs.io
GNU Affero General Public License v3.0
6 stars 2 forks source link

error _buffer_to_frame #34

Open MarcelMB opened 1 month ago

MarcelMB commented 1 month ago

Screenshot 2024-07-11 at 4 47 40 PM (1)

Running into this error for the newest release on main f11d901

Had already talked with @t-sasatani about it. decided to get the full binary output with: mio stream capture -c /Users/mbrosch/Documents/GitKraken_mac/miniscope-io/miniscope_io/data/config/WLMS_v02_200px.yml -b binary_error_test.bin

Download the binary file

sneakers-the-rat commented 1 month ago

Off by 1 error? Ill take a look in a minute

t-sasatani commented 1 month ago

Yes, this itself seems like it can be patched by doing one or two error handling. I wanted it here also because we might want to look closely at how a (presumably) broken buffer generally affects image construction and consider whether we're doing the right amount of carefulness.

t-sasatani commented 1 month ago

To dos