Kill Log buggy when changing player vision

[Ahli]

Changing player vision bugs the kill log.

quest icon vertical size wrong

wrong killer color - Sylvanas is blue, should be red

[Ahli]

Facts:

• Kill log colors are wrong when the killer is in the red team and the observer was in a player vision of the red team when the slot was created. Then it is blue instead of red
• Changing player vision moves all slots to the top of the panel, so they overlap each other
• Changing player vision breaks quest item vertical size TODO find out why
• Victim color is based on the alliance setting and is updated on vision change in default UI. Killer color is not updating on vision change. The color it received on creation persists (which is blue when following the red team's player vision)

[Ahli]

Colors of default UI and fix steps for each situation

Challenges:

• identify red player vision team color on creation (use in stategroup that sets colors => apply correct color in each situation) => ViewPulldown has a team-sorted index instead of player number sorted => assuming 5vs5, then red team is selectedIndex 6-10 => player-vision-of-selected-unit shows a player colored image => detect red team (or skip that because nobody uses that feature) => non 5vs5 solution would need to count the amount of players per team (=> hero portrait slot in the top panel is visible)
• store the information of being in the red team's vision or not when the entry became visible

[Ahli]

I have fixed the icon color issues.

• However, now the cutscene background is sometimes not visible.
• Also, the colorblind color is swapped back to the default color after changing player vision.

[Ahli]

The colors are now fixed.

Blizzard also had a bug with colorblind support in the background cutscene as the ally/enemy animation clears the colorblind filter. The animation clears all filters which removes the colorblind filter. Thus, the colorblind filter never functions. => They need to remove the red/blue team filters only and it will work. That's exactly what my fix is doing, but I cannot alter the existing animation => I created a 2nd background and hid the original one.

[Ahli]

anther quest icon vertical size bug

[Ahli]

Current state:

Documentation of the color fix for observers

The issue

• colors change when player vision changes
  • observers want the left team to be blue and the right team to be red, Always!

Analysis Analysis of the default UI's behavior from Observer's perspective (=> left team always blue, right team always red): Red = wrong, Green = correct, Implemented stategroup cases are on the right side

The code to fix the colors for observers is here.

Notes

• The fix requires to know, if the entry was created during red team's player vision. A stategroup can save that information.
  • The vision is detected via the selected index of the vision pulldown and it assumes that it is a 5vs5. Outside these scenarios, the detection is wrong
    • a perfect detection is in theory possible (top panel's portrait slots => player count per team) but was not feasible to be implemented

Fix analysis

• The color issue seem to be fixed and seems to work 100% reliable for 5vs5s.
• Fixed the appearance of suicides, so a blue Chen killing a blue Chen has a red background as it benefits the red team

.

.

.

Documentation of the colorblind fix for the background cutscene color

The issue

• the BackgroundCutscene implements the CutsceneColorblindFilterSupport, but it will not show colorblind colors

Analysis

• The colorblind option adds a filter, if colorblind is enabled for the user
• The animations PlayBg_Ally and PlayBg_Enemy are removing all filters via ClearFilters. -- This removes the colorblind filter as it is added before the animations are started (triggered via stategroup). -- The fix: ClearFilters can be replaced by RemoveFilter

Since editing existing animations does not work reliably, a second background was implemented and the original one hidden. The suggested fix in the animations works. The implementation is here.

Fix analysis

• The colorblind option now changes the colors of the background cutscene.
• Creating a second background cutscene and hiding the default one is not optimal. If the default one's animation can be fixed, that should be preferred

.

.

.

Remaining issues

• positions are wrong
  • seems to work if vision was changed during the SlideUp animation. The animation seems to update the position
• sometimes quest icons and their borders are stretched vertically
  • only happens sometimes, but 100% repeatable)
  • only happens during player vision changes