Ahli / sc2xml

11 stars 1 forks source link

Guardian Shield "ability search flag: Same Cliff Level" is turned on despite shield model encompassing units #123

Closed Joshua-Leibold closed 6 months ago

Joshua-Leibold commented 10 months ago

Guardian shield will not shield units on another cliff level, even though they are very clearly inside the shield bubble. This is especially odd for air units, which will gain and lose guardian shield as they fly over various terrain even while still inside the regular radius.

In principle, after disabling the Same Cliff flag there is the potential for the reverse problem where sometimes units outside the shield may receive protection. However, in practice, after the cliff patch it's extremely rare where a sentry is placed more than one level away from another unit while it is still being within Guardian Shield's range (the only time where this is really possible for ground units to escape the bubble; you have to have some kind of vertical difference). Additionally, units that receive protection will always have the little "animation" play signaling they have gained protection, even if they are outside the bubble, which can make up for that problem, whereas no such animation exists for the current problem (for instance, you lose it if you walk down a ramp).

XML Data Changes:

<CEffectEnumArea id="GuardianShieldSearch">
        <SearchFlags index="SameCliff" value="0"/>
    </CEffectEnumArea>

https://i.gyazo.com/e80bec712b9db49cae0b925fad9bef33.jpg

Joshua-Leibold commented 6 months ago

Successfully patched live with 5.0.13