search

Ahli / sc2xml

11 stars 1 forks source link

Reaper KD-8 animation did not complete before explosion #127

Open Joshua-Leibold opened 8 months ago

Joshua-Leibold commented 8 months ago

I have no idea how to replicate this but I experienced it in the test document and wondered if the live game would behave similarly so I loaded up Battle.net and hopped into a match and it was still there. When I went back to the test document to look for the issue, it magically corrected itself

Early Detonation: https://i.gyazo.com/9df7f97b3b948136fd159e48df1e7d74.gif

It's very possible this bug has been around for years, given that this video features something similar: https://www.youtube.com/watch?v=Wve31MiGk58

How the full animation looks: https://i.gyazo.com/b5648bcd1ff91aa4d56ec0d409e6856c.gif

It should be noted that the animation speed on the model is set to 3 rather than 1, so my guess is that the animation adjustment didn't register for some reason so it only finished 1/3

Ahli commented 8 months ago

Since the issue exists, I would try setting the speed up animation differently.

I doubt that the actor's global timescale modifier would fail:

    <CActorUnit id="KD8Charge">
        <On Terms="ActorCreation" Send="AnimSetTimeScaleGlobal 3.000000"/>
    </CActorUnit>
    <CModel id="KD8Charge">
        <AnimSpeed value="1.000000"/>
    </CModel>

Since I fail to recreate the issue, I can't tell if that really fixes it. But it is worth a fix attempt, I guess

Joshua-Leibold commented 6 months ago

Patch 5.0.13 appears to have broken the animation further. We intended to move the x3 animation speed multiplier from the unreliable model multiplier to the more reliable animation multiplier...

Patch 5.0.13 successfully added the x3 multiplier to the actor, but did not remove the x3 multiplier from the model, so now the KD-8 animation never works because it finishes the moment it starts