Baneling causes double damage on ramps due to different cliff level

[Ahli]

https://github.com/Ahli/sc2xml/issues/63 causes the fallback damage to hit the targeted unit twice when the unit is on a different cliff level

video

Fix

The issue can be fixed via markers. The Hellion uses the same solution to only damage units once.

Here, the fallback damage will only execute when the unit has not been damaged by the weapon, yet.

    <CEffectDamage id="VolatileBurstDirectFallbackEnemyNeutralBuilding">
        <ValidatorArray value="noMarkers"/>
    </CEffectDamage>
    <CEffectDamage id="VolatileBurstDirectFallbackEnemyNeutralUnit">
        <ValidatorArray value="noMarkers"/>
    </CEffectDamage>
   <!-- clean up Set having two effects registered that do not exist and were not necessary -->
    <CEffectSet id="BanelingVolatileBurstDirectFallbackSet">
        <EffectArray index="2" removed="1"/>
        <EffectArray index="3" removed="1"/>
    </CEffectSet>

    <CWeaponLegacy id="VolatileBurst">
        <Marker>
            <MatchFlags index="Id" value="1"/>
        </Marker>
    </CWeaponLegacy>
    <CWeaponLegacy id="VolatileBurstBuilding">
        <Marker>
            <MatchFlags index="Id" value="1"/>
        </Marker>
    </CWeaponLegacy>

test map

Summary

original Blizzard implementation

• Banelings did not deal damage to structures/units close to cliffs, but on a different cliff level like Colossus

fix from last year

• Banelings dealt damage to structures/units close to cliffs, but on a different cliff level
• Banelings can deal damage twice to primary target when attacking on ramp

this version

• Banelings dealt damage to structures/units close to cliffs, but on a different cliff level
• Banelings cannot deal double damage