Researching Hi-Sec Auto Tracking does not increase its upgrade level

[Joshua-Leibold]

Ingame: https://i.gyazo.com/044980e92e356199dfcf0f02f63b786a.gif

<CUpgrade id="HiSecAutoTracking">
     <EffectArray Reference="Weapon,AutoTurret,Level" Value="1"/>
     <EffectArray Reference="Weapon,LongboltMissile,Level" Value="1"/>
     <EffectArray Reference="Weapon,TwinIbiksCannon,Level" Value="1"/>
</CUpgrade>

After fix: https://i.gyazo.com/15c248a98b17543bf4f7120517efc782.gif

[Ahli]

I don't like non-damage upgrades altering the level label due to inconsistency.

For example, Hydralisk's Grooved Spines upgrades are not raising the level label and shouldn't.

[Joshua-Leibold]

You are correct that Hydralisk Grooved Spines should not raise the level upgrade. However, Grooved Spines's icon does not appear on the unit info panel so does not require a level upgrade effect

This is the Grooved Spines (research) icon:

This is the Hydralisk (generic zerg ground missile) unit info panel icon:

This is the Hi-Sec Auto Tracking (research) icon:

This is in contrast to the missile turret which does use the dedicated Hi-Sec Auto Tracking icon on the unit info panel (the button is even called Hi-Sec auto tracking in the files: there is no "generic ranged building attack" icon) :

If the spore crawler had a range upgrade, I would agree the level should not be increased since the spore crawler uses the ranged ground attack icon like the hydralisk and presumably that ranged upgrade would use a separate hypothetical icon. However, unless you're planning on changing the Terran structures to not share an icon with Hi-Sec Auto Tracking, this change keeps things intuitive and consistent.

I've also still got the more practical gameplay application on my side. There is currently no way to increase the upgrade level of the Hi-Sec Auto Tracking unit info panel icon by other means, making increasing the level unambiguous (one does not need to hover over the Hi-Sec icon to know what has changed, it will always signal the range as the upgrade research button describes). This in contrast to something like Grooved Spines or Resonating Glaives, which if the upgrade level increased the Zerg ground missile or Protoss Ground weapon upgrade level, would cause the level increase to be always ambiguous even if just researching +1 weapons.

Very anecdotally: I have an embarrassing amount of times wondered myself if my mutas, medivacs etc. were getting hit by Hi-Sec auto tracking and I have mistakenly clicked on the turret to look at the unit info panel icon to check for upgrades like I would any other unit, seen no upgrade level on the attack, and incorrectly concluded the weapon was not modified