search

Ahmadre / FlutterIconPicker

An adaptive comprehensive IconPicker for Flutter
MIT License
116 stars 78 forks source link

Is it slow to open or it's just me? #1

Closed spidgorny closed 4 years ago

spidgorny commented 4 years ago

Great widget. Exactly what I need. It's a little slow to start. The app freezes for 1-2 seconds before the the popup appears. My device is OnePlus 3T. Is it going in a loop generating all the icons every time? Could we pre-generate an array of icons and put as a const array in dart file?

Ahmadre commented 4 years ago

Thank you for filing this issue.

I also encountered this issue. Glad that I was not alone. Actually it assigns the Map in the method _buildIcons with a forEarch loop. Thank you also for the suggestion. Did you test it? Does it work with const? I can't test it now, but any PR's are very welcome :)

Best regards Rebar

Ahmadre commented 4 years ago

Ok, I am working on a solutions. Already set const, but I have to render the InkResponse async.

But for your information: on my release app in Pixel 2 XL it's a little bit faster with opening. If I update to 0.1.5, test it with flutter run --release

Ahmadre commented 4 years ago

Alright, new release is online. Just try it out and let me know :)

Ahmadre commented 4 years ago

As you can see the picker is loading directly. You have to build a release app. closing this issue due to it's loading now directly

spidgorny commented 4 years ago

Thank you for a quick feedback and a fix. Version 1.1.5 is still slow for me. Maybe it's just my device performance.