search

Ahmadre / FlutterIconPicker

An adaptive comprehensive IconPicker for Flutter
MIT License
112 stars 76 forks source link

How to add multiple icon packs to choose from? #34

Closed xrayian closed 2 years ago

xrayian commented 2 years ago

I want to add all the icon packs to the widget but couldn't figure out how to do it!

Ahmadre commented 2 years ago

I want to add all the icon packs to the widget but couldn't figure out how to do it!

Very good point! I'll try to add this feature asap :)

Ahmadre commented 2 years ago

@xrayian Just implemented that feature for you :) and updated new Version: 3.1.0.

Old api's where documented and marked as deprecated.

You can now use: iconPackModes.

CustomIconPacks are also respected and inlcuded 👍🏼

xrayian commented 2 years ago

Thanks man! 👍👍

jlnrrg commented 2 years ago

@Ahmadre Using iconPackModes: [IconPack.custom], still includes the material IconPack beside the custom provided. Which is a bug I guess.

Ahmadre commented 2 years ago

@Ahmadre

Using iconPackModes: [IconPack.custom], still includes the material IconPack beside the custom provided.

Which is a bug I guess.

Oh yeah thanks it was because I tried to deprecate the old interface. I will delete iconPackMode completely.

Ahmadre commented 2 years ago

@jlnrrg fixed and published on v. 3.1.1 :)

jlnrrg commented 2 years ago

Sorry for questioning, but are you sure about it? I use the version 3.1.1 and also did a flutter clean.

The following code is not working:


final v = await FlutterIconPicker.showIconPicker(
                        context,
                        adaptiveDialog: false,
                        showTooltips: true,
                        iconPackModes: [IconPack.custom],
                        customIconPack: Constants.icons,
                      );
Ahmadre commented 2 years ago

Sorry for questioning, but are you sure about it? I use the version 3.1.1 and also did a flutter clean.

The following code is not working:

final v = await FlutterIconPicker.showIconPicker(
                        context,
                        adaptiveDialog: false,
                        showTooltips: true,
                        iconPackModes: [IconPack.custom],
                        customIconPack: Constants.icons,
                      );

You're totally right. Bildschirmfoto 2022-01-04 um 03 44 22

It was that line where icons where returned as default.

Fixed it now :3

Ahmadre commented 2 years ago

Sorry for questioning, but are you sure about it? I use the version 3.1.1 and also did a flutter clean.

The following code is not working:

final v = await FlutterIconPicker.showIconPicker(
                        context,
                        adaptiveDialog: false,
                        showTooltips: true,
                        iconPackModes: [IconPack.custom],
                        customIconPack: Constants.icons,
                      );

v. 3.1.2 is uploaded. Thanks for your help :3

jlnrrg commented 2 years ago

Thank you for fixing it this fast :+1: