[Issue-38] FlutterIconPicker not updating to current params

Ahmadre / FlutterIconPicker

An adaptive comprehensive IconPicker for Flutter

MIT License

112 stars 76 forks source link

[Issue-38] FlutterIconPicker not updating to current params #39

Closed veloso14 closed 2 years ago

veloso14 commented 2 years ago

Regarding the issue 38

I have tested under my previous scenario and these changes seem to fix the problem. I used provider and ChangeNotifier for this. Additionally, I noticed that if you passed iconPackModes: null, and customIconPack: null, you could solve the previous issue on the current version. Let me know what you think @Ahmadre

Ahmadre commented 2 years ago

Thank you for your PR :)

I saw that you created the Provider with create parameter. Actually the best practice for provider is to create one with value parameter.

But regarding the actual package, I have to check it twice when I'm home again.

Are there Consumers for the IconPicker and Searchbar?

Ahmadre commented 2 years ago

Analyzer is also failing. Maybe you can check that.