search

Ahmadre / FlutterIconPicker

An adaptive comprehensive IconPicker for Flutter
MIT License
112 stars 76 forks source link

Update icons #42

Closed CripyIce closed 2 years ago

CripyIce commented 2 years ago

After upgrading to Flutter 2.10.2, there is a new error regards to an icon being removed.

    ../../.pub-cache/hosted/pub.dartlang.org/flutter_iconpicker-3.1.2/lib/IconPicker/Packs/Material.dart:4894:31: Error: Member not found: 'pie_chart_outlined'.
      'pie_chart_outlined': Icons.pie_chart_outlined,
                                  ^^^^^^^^^^^^^^^^^^
potay commented 2 years ago

+1

nicolashasenkopf commented 2 years ago

+1

ccfiel commented 2 years ago

same here

corioste commented 2 years ago

added fixed https://github.com/Ahmadre/FlutterIconPicker/pull/43

ccfiel commented 2 years ago

@Ahmadre can you please merge the main branch. thanks!

Ahmadre commented 2 years ago

Thanks guys. I'll also check the newest Icons and update them also after the merge request

RohanPatil1 commented 2 years ago

Any Update on this??

ameenvga commented 2 years ago

any update?

anderson-oki commented 2 years ago

Maybe we should find a way to remove the dependancy of the Packs. They have been introducing breaking changes several times in Material and FontAwesome.

hesty98 commented 2 years ago

When will this be published?

Apfelwurm commented 2 years ago

am i wrong or wouldn't be the fix to just change it from 'pie_chart_outlined' to 'pie_chart_outline' due to https://github.com/flutter/flutter/pull/96115 ? and also it would be really cool if this would get into a new version

Ahmadre commented 2 years ago

Hi guys!

Sorry for the delay 😔 I was very busy with 3D projects.

I will publish a new version with the fixes today ☺️

Apfelwurm commented 2 years ago

cause it seems @Ahmadre had no time, for all that come across this issue, you can temporary use the git provider in your pubspec like this to obtain the fixed version:

dependencies:
  flutter_iconpicker:
    git:
      url: https://github.com/Ahmadre/FlutterIconPicker.git
      ref: master

keep in mind that this is not a change you should make forever, since there will maybe be experimental changes on the master here before a future release. You could also set the ref to a318bbe4ac4b318549234cf7354bdcd9faf88b16 which referes to the current fixing commit, but that is also nothing you should have permanently, since it wont get updated if there are new versions or commits

HasimD commented 2 years ago

We are still waiting for the new version... Thank you so much @Ahmadre

Ahmadre commented 2 years ago

New Release is up guys Version