search

Ahmadre / FlutterIconPicker

An adaptive comprehensive IconPicker for Flutter
MIT License
112 stars 76 forks source link

fix missing fontPackage in serialzation #5

Closed lisuizhe closed 4 years ago

lisuizhe commented 4 years ago

Hi Ahmadre, thank you for your IconPicker.

I use it in my flutter project and find out this bug that the serialization logic is missing 'fontPackage' param, making not possible to deserialize correctly for icondata other than official Flutter Icon.

Ahmadre commented 4 years ago

Hi @lisuizhe ,

thank you so much for your contribution :).

Did you test your changes to the default material iconPack? Is it also working for IconData which don't have the attribute fontPackage? If there aren't any errors it looks very good!

Thanks

Rebar

lisuizhe commented 4 years ago

Did you test your changes to the default material iconPack?

Yes

Is it also working for IconData which don't have the attribute fontPackage?

After a quick search I could not find IconData without fontPackage. But IMO the logic of serialization support null fontPackage and should not result in error. Event it it null the result is codePoint could not be found in default fontPackage(material) and Icon will be shown like a □

thx

Ahmadre commented 4 years ago

LGTM. I will update version and upload a new pub-version. Thanks 👍🏼