Ahmadre / FlutterIconPicker

An adaptive comprehensive IconPicker for Flutter
MIT License
112 stars 76 forks source link

Opening really slow #7

Closed frederikw03 closed 4 years ago

frederikw03 commented 4 years ago

When i click Open IconPicker it takes about 3 seconds before it opens. is it possible to remove some icons to make it open faster? i don't need all the icons. is it also possible to add icons myself as the developer?

Ahmadre commented 4 years ago

@frederikw03 Thank you for your issue!

Like you saw in previous issues, it was tried to fix this, but best solution would be infinite scrolling. If you like you can contribute to this project. All contributions are welcome :).

Actually I'm a bit busy.

Best regards and thanks for using this package 💪🏼

leonardarnold commented 4 years ago

Hi Rebar, thanks for the package!

I am using it for a prototype and stumbled on the same issue. The delay is because the list is a SingleChildScrollView with a Wrap as a child. With so many items it's heavy. I could fix it by replacing it with a GridView.builder. The performance now feels like 1000 times better.

I didn't do a PullRequest because this breaks your adaptive layout a bit and needs some logic for responsiveness.

I forked it here: https://github.com/leonardarnold/FlutterIconPicker.

Tell me if you need more code to fix this.

Stay safe! :)

Screenshot 2020-06-17 at 19 07 36 Screenshot 2020-06-17 at 19 01 55

Ahmadre commented 4 years ago

@leonardarnold Thank you soo much for your work :)!! Really appreciate it!

Don't worry I got a responsive solution for a responsive GridView. I did that earlier for a customer project. I'll have a look and improve it :)

Thank you, thank you, thank you!

NiamhG commented 4 years ago

Hey, just wondering if you had a timescale for adding in your fix @Ahmadre ? Not wanting to rush, just curious.

Love the project btw, was exactly what I needed :)

Ahmadre commented 4 years ago

Hey guys, sorry for the long delay. I will do that now and let you know if an update was uploaded :)

Ahmadre commented 4 years ago

Alright guys: new Update is up: Version

+++ creating your own IconPacks and provide it to the picker +++ performance fixes from @leonardarnold :)

NiamhG commented 4 years ago

Works beautifully, thanks again @Ahmadre !

frederik0312 commented 4 years ago

Is it possible to get the icons real color? Or how could i do this? Thanks i really like the update

Ahmadre commented 4 years ago

@frederik0312 The iconColor is reacting to Theme changes so it is also compatible with darkTheme for example.

But you can control the iconColor on your own if you like. Have a look into the API-Reference: https://github.com/Ahmadre/FlutterIconPicker#api-reference on the section: iconColor

frederik0312 commented 4 years ago

Thanks for the answer, but i meant more like the icons true color. Like blue Facebook, yellow snapchat , and some multicolored like Instagram?

Ahmadre commented 4 years ago

@frederik0312 Ah I know what you mean. Actually that would be a good question for the owners of the FontAwesome Package.

Or would you expect this to be in this package?

Because such things belong to specific implementations and there should be a generic api for handling customized things 🤔

Let me know and maybe we can work on a practical solution :)

frederikw03 commented 4 years ago

Honestly i would LOVE it to be in this package. It would be awesome to have it all together


From: Rebar Ahmad notifications@github.com Sent: Monday, August 3, 2020 8:06:24 PM To: Ahmadre/FlutterIconPicker FlutterIconPicker@noreply.github.com Cc: Frederik Wennerstrøm fwen@itu.dk; Mention mention@noreply.github.com Subject: Re: [Ahmadre/FlutterIconPicker] Opening really slow (#7)

@frederik0312https://github.com/frederik0312 Ah I know what you mean. Actually that would be a good question for the owners of the FontAwesome Package.

Or would you expect this to be in this package?

Let me know and maybe we can work on a practical solution :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Ahmadre/FlutterIconPicker/issues/7#issuecomment-668164560, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN2XETQJMU5HBD5ZGVUAYITR634CBANCNFSM4NIOBCYA.