search

Ahmadre / FlutterIconPicker

An adaptive comprehensive IconPicker for Flutter
MIT License
112 stars 76 forks source link

Make dcli devDependency as it is for generating packs #70

Closed mennovanhout closed 2 months ago

mennovanhout commented 3 months ago
  1. Bumping dependency versions.
  2. Changed dcli and args into devDependencies as they are for creating packs

Currently this package is witholding other packages due constraints of dcli

Ahmadre commented 2 months ago

Thank you so much for your PR!

I will also have a look at the wait_for bug, or was is due to dcli package?

mennovanhout commented 2 months ago

Thank you so much for your PR!

I will also have a look at the wait_for bug, or was is due to dcli package?

That one is still there, i was checking it out but didn't get to it yet!

Ahmadre commented 2 months ago

This PR is not working:

Bildschirmfoto 2024-05-27 um 16 14 54
Ahmadre commented 2 months ago

dcli and args were not in dev_dependencies, because once a user installed this package it should be shipped to generate packs. I have to revert this.

Ahmadre commented 2 months ago

i will update the dependencies and fix everything.

Ahmadre commented 2 months ago

Fixed dcli package for the wait_for bug.