Support dark mode - Githubissues

Ahmed-Ali / JSONExport

JSONExport is a desktop application for Mac OS X which enables you to export JSON objects as model classes with their associated constructors, utility methods, setters and getters in your favorite language.

Other

4.8k stars 794 forks source link

Support dark mode #124

Closed kevnm67 closed 5 years ago

kevnm67 commented 5 years ago

Issue :construction:

Checkbox text isn't visible when dark mode is enabled.
Mac Mojave with dark mode enabled

Current Behavior :mag:

'Constructor' and other checkbox text isn't visible.

Steps to Reproduce

Run JsonExport using Mojave with dark mode enabled.

Screen shots

PlutusCat commented 5 years ago

You can edit this Main.storybiard and recompile.

huabin commented 5 years ago

@kevnm67 Hello, I have fixed this and submitted a PR to the developer, and you can use my version from https://github.com/hzb/JSONExport if you don't want to wait, or you can download the application from https://www.dropbox.com/s/20dm3241jdiwq7p/JSONExport.zip?dl=0, thank you.

kevnm67 commented 5 years ago

@hzb I'll check it out. Thanks!

huabin commented 5 years ago

@kevnm67 You are welcome. BTW if it works well, please close this issue, if not, please append the error, I will fix.

kevnm67 commented 5 years ago

@hzb Just verified the change locally. Looks good. Thoughts on referencing this issue in your PR? (e.g. fixes #124). Github will automagically close this issue once your PR is closed/merged.