Ahmed-Ali / JSONExport

JSONExport is a desktop application for Mac OS X which enables you to export JSON objects as model classes with their associated constructors, utility methods, setters and getters in your favorite language.
Other
4.79k stars 794 forks source link

Load JSON data from web #151

Closed rogys88 closed 10 months ago

rogys88 commented 1 year ago

Fixed issue (#148) - App getting crash while passing proper json.

Task/Issue URL: https://github.com/Ahmed-Ali/JSONExport/issues/148

rogys88 commented 1 year ago

Support for loading JSON data from web

@Ahmed-Ali Thanks for this amazing product and thanks to make my life easier. 🙂

I also change the text "Enter json data or" to "Enter json data/url or" and Update README To Do list: Load JSON data from web Done

Screen Shot 2022-10-18 at 1 47 21 PM
Ahmed-Ali commented 1 year ago

Hi @rogys88, first off thank you so much for the PR! second off, I am really sorry it took so long to get to it. I promise I will do my best to be much more attentive for future PRs.

Lastly, if you can kindly revise the PR to resolve the conflicts, and update it to request to merge to develop instead of the master branch, that would be really appreciated!

rogys88 commented 10 months ago

Hi @rogys88, first off thank you so much for the PR! second off, I am really sorry it took so long to get to it. I promise I will do my best to be much more attentive for future PRs.

Lastly, if you can kindly revise the PR to resolve the conflicts, and update it to request to merge to develop instead of the master branch, that would be really appreciated!

I just did it 😉

Ahmed-Ali commented 10 months ago

Thanks @rogys88! I believe you did that in PR #153 which is now merged. Hence I will close this one.