AhmedElywa / prayCalendar

Generate Pray Calendar Subscribe
https://pray.ahmedelywa.com
6 stars 1 forks source link

Delayed prayer times by 4 hours #2

Closed Maxiwld closed 2 months ago

Maxiwld commented 4 months ago

Hello Ahmed,

I really like your project! Thanks a lot. When subscribing to the URL for Abu Dhabi I noticed that prayer times in outlook don't match the expected prayer times with a consistent lag of +4 hours. Could you help me troubleshoot this issue, perhaps?

Correct prayer times image

Result after subscribing to https://pray.ahmedelywa.com/api/prayer-times.ics?address=Abu%20Dhabi&method=5&alarm=5&duration=25

Thanks in advance and best regards, Max

AhmedElywa commented 4 months ago

The method is so important you use the Egyptian calculation you should use what is used in the UAE. I think it's Umm Alqura

image

AhmedElywa commented 4 months ago

image

Maxiwld commented 3 months ago

Hello Ahmed,

thanks for your swift reply! That's good to know. I created an overview of which method can be used in which region (using ChatGPT) - maybe it makes sense to include it in the readme or even on the website to help users like me? Sharing below.

<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

Method | Countries/Regions -- | -- Shia Ithna-Ashari | Commonly used by Shia Muslims worldwide University of Islamic Sciences, Karachi | Pakistan Islamic Society of North America | United States, Canada Muslim World League | Several countries, including Europe, the Far East, and parts of the Middle East Umm Al-Qura University, Makkah | Saudi Arabia Egyptian General Authority of Survey | Egypt, and some countries in Africa Institute of Geophysics, University of Tehran | Iran Gulf Region | Gulf Cooperation Council (GCC) countries Kuwait | Kuwait Qatar | Qatar Majlis Ugama Islam Singapura, Singapore | Singapore Union Organization islamic de France | France Diyanet İşleri Başkanlığı, Turkey | Turkey Spiritual Administration of Muslims of Russia | Russia Moonsighting Committee Worldwide (also requires shafaq parameter) | Countries worldwide using moonsighting for Islamic calendar

I followed your advice and tried again using the "GCC Region" Method and "Abu Dhabi" as location. However, the issue persists. (see screenshot)

Result after importing: https://pray.ahmedelywa.com/api/prayer-times.ics?address=Abu%20Dhabi&method=5&alarm=5&duration=25 Prayer time bug

+4 hours delayed results displayed compared to actual timing (see below) - https://islamuna.com/prayer-time/united-arab-emirates/abu-dhabi image

Could the delta perhaps be caused by it being created in UTC instead of UTC+4 in which my calendar is being displayed?

AhmedElywa commented 3 months ago

We give you the time with UTC and your calender should convert it to your local time so your issue is coming from you calendar test it with another one