search

AhmedNazirMusah / Recipe-app

0 stars 1 forks source link

[0.5pt] Setup Kanban board for Recipe App #10

Open AhmedNazirMusah opened 1 year ago

AhmedNazirMusah commented 1 year ago

We are only two people in this group

Link to our kanban board :

https://github.com/users/AhmedNazirMusah/projects/1

TedLivist commented 1 year ago

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑

Hi @UsirusenIkon and @AhmedNazirMusah,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You need to provide the link to the Kanban board also.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

TedLivist commented 1 year ago

STATUS: INVALID CODE REVIEW REQUEST 🛑 🛑

Hi @UsirusenIkon and @AhmedNazirMusah,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

Your link displays a 404 page. Kindly ensure the repo is not private.

image

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

ichala commented 1 year ago

Hi Team Good job so far! 👏👏👏 You still need to work on some issues to go to the next project, but you're almost there!

the-simpsons-homer-simpson

To Highlight 🎉

kindly make sure that all cards on the board have:

- the number of points in the [Xpt] prefix. That number should indicate the number of points showing the complexity of the task.1 point = 1 hour of work. - a description of the task.

⚠️ currently, there are some cards that don't have Points or/and descriptions, kindly fix that

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

m05e5 commented 1 year ago

**Hi @AhmedNazirMusah

You did great. Your kanban board is complete! There is nothing else to say other than... its time to start coding :shipit: Congratulations! 🎉 CleverScornfulBuffalo-size_restricted

Highlights

✔️ Clean kanban board

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

m05e5

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.**