search

AhmedShaiyan / pe

0 stars 0 forks source link

Error handling for spaces between commands is not specific #2

Open AhmedShaiyan opened 3 months ago

AhmedShaiyan commented 3 months ago

entering a valid expense tracker command but forgetting a spaces gives "unknown command". Could be more specific.

example: input without space between e/ and add/

image.png

nus-pe-bot commented 3 months ago

Team's Response

As per the UG, warning for input format has been clearly highlighted in BOLD and RED for the user to ensure spaces are used. omitting it is a user error which have been highlighted to the user, hence not a bug in the error message image.png

image.png

This is an invalid command and behaves as expected image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While I understand that the UG provides caution regarding proper spacing, I do not think that is reason enough to not have specific error messages for the issue. Infact, your program already has a suitable error message for cases when the spacing is incorrect:

image.png

However, this message is not always invoked for spacing error cases. The message your program currently outputs for some wrong spacing situations is this:

image.png

(no space between e/ and add/).

Such vague error messages is considered a bug.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Given the inconspicuous nature of whitespaces, not specifying this error and simply outputting "unknown command" leaves the user to do a lot of work trying to figure out what is wrong with their input. Such an inconvinience can occur quite frequently given how easy it is to miss a space while typing on the CLI. Therefore, it is definitely not a cosmetic issue and hinders the usage of the program"